search

essandess / etv-comskip

Commercial Marking and Skipping for EyeTV and iTunes Exports
GNU General Public License v2.0
55 stars 7 forks source link

MarkCommercials starts too soon and tries to open empty video file #52

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Standard install and use. Most of my recordings are not processed.
2.
3.

What is the expected output? What do you see instead?
MarkCommercials tries to open a video file that isn't ready yet.

What version of the product are you using? On what operating system?
EyeTV 3.5.4 (6788) - EyeTV One
ETVComskip-2.0.2-10.6.dmg (modified now)
OS X 10.7.3

Please provide any additional information below.

Increasing the delay in the applescript only delays the start of the recording 
so it didn't (shouldn't) help.

The delay needs to get put into the shell script so that RecordingStarted can 
exit and start the recording. Then 60 seconds later MarkCommercials has 
something to work with.

Here it is: added "(sleep 60 ; " at the start and ")" after recordingID.

on RecordingStarted(recordingID)
    set cmd to "(sleep 60 ; /usr/bin/nice -n 2 '/Library/Application Support/ETVComskip/MarkCommercials.app/Contents/MacOS/MarkCommercials' --log " & recordingID & ") &> /dev/null &"
    -- display dialog cmd
    do shell script cmd

Original issue reported on code.google.com by bgrupczy...@gmail.com on 1 Mar 2012 at 3:06

GoogleCodeExporter commented 8 years ago 
Relooked at this and I don't think I'm so right. I've got alot of other 
processes going on right now and I didn't account for them. I think it takes 
the tuner some time to get a lock on the signal some times.

Sorry for the chatter.

But this does work as well.

Original comment by bgrupczy...@gmail.com on 1 Mar 2012 at 5:10