essandess / etv-comskip

Commercial Marking and Skipping for EyeTV and iTunes Exports
GNU General Public License v2.0
55 stars 7 forks source link

RecordingDone.scpt -- unique ID converts to exponential notation #6

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Run RecordingDone.scpt manually
2. in terminal, run ps auxwww |grep -i etvcom
3. See that the program id is in exponential notation

Eg:
/Library/Application
Support/ETVComskip/MarkCommercials.app/Contents/MacOS/MarkCommercials --log
2.31395579E+8

It should be:
/Library/Application
Support/ETVComskip/MarkCommercials.app/Contents/MacOS/MarkCommercials --log
231395579

I don't really know applescript, but this seems to work:
Change:
        my RecordingDone(rec)
to:
        my RecordingDone(rec as integer)

I don't know if it breaks when the script is run automatically by EyeTV.

Original issue reported on code.google.com by cocc...@gmail.com on 2 May 2008 at 7:19

GoogleCodeExporter commented 8 years ago
Good point.  However, running RecordingDone manually is intended *only* for 
testing
during development, as it's just hard-coded to run MarkCommarcials on the first
recording in the EyeTV library.  If you're actually trying to manually mark
commercials, you should run MarkCommercials:

/Library/Application\
Support/ETVComskip/MarkCommercials.app/Contents/MacOS/MarkCommercials all

Original comment by jon.chri...@gmail.com on 2 May 2008 at 7:33

GoogleCodeExporter commented 8 years ago
So this bug doesn't arise when the script is run automatically? I thought maybe 
that
was why commercials weren't detected for me in new recordings. 

Original comment by cocc...@gmail.com on 2 May 2008 at 9:15

GoogleCodeExporter commented 8 years ago
It works for me.  What happens if you run MarkCommercials manually on a 
recording? 
What's in the log file (in ~/Library/Logs/ETVComskip)?

Original comment by jon.chri...@gmail.com on 2 May 2008 at 5:01