search

essencebit / SignalRSwaggerGen

MIT License
70 stars 8 forks source link

Upgraded to .net 7.0 #40

Closed mahmmoudkinawy closed 1 year ago

mahmmoudkinawy commented 1 year ago

Kindly review the latest updates and confirm if they meet the required standards. If everything is in order, I have additional updates that may also require your attention.

Dorin-Mocan commented 1 year ago

@mahmmoudkinawy , first of all thanks for trying to contribute, it's much appreciated. Could you please elaborate on why we need to upgrading to .NET 7? What is the actual issue that you have with the current version? Current version supports netstandard 2.0 and 2.1.

mahmmoudkinawy commented 1 year ago

@Dorin-Mocan Hello there there is no issues I got at all with the current version! Just I thought that .net 7.0 is much better than 2.0 ... etc Fast, better Performance, offers good code structure. And just there exist something I wish you do so! The documentarion is very small! There is no details for it and if you want I can help you in that.

Dorin-Mocan commented 1 year ago

@mahmmoudkinawy for nuget packages it is recommended to use the the lowest possible version of netstandard, to be able to support as many platforms as possible. That's why my package is written on top of netstandard 2.0 and 2.1. As for the speed, this is not a necessity for this package, because it builds the swagger documentation just once at app startup and the chance that there'll be a hundred of billions of signalr hubs that will slow down the processing is practically equal to zero. In any case, thanks for the intention to help.