Wrong itCanBeRenderedInBottom

essetwide / material-walkthrough

A material tour (eg Inbox from Google).

https://essetwide.github.io/material-walkthrough/

Apache License 2.0

32 stars 10 forks source link

Wrong itCanBeRenderedInBottom #39

Closed AirMike closed 6 years ago

AirMike commented 6 years ago

I think there is a typo which leads to wrong itCanBeRenderedInBottom prediction (v2 branch)

var itCanBeRenderedInBottom = position.y + MaterialWalkthrough._contentWrapper.offsetHeight + MaterialWalkthrough._contentWrapper.offsetHeight < window.innerHeight;

There are two MaterialWalkthrough._contentWrapper.offsetHeight where one of them should be MaterialWalkthrough._wrapper.offsetHeight.

menosprezzi commented 6 years ago

That's right! I'll gonna fix it now.

Thanks @AirMike.