search

essetwide / material-walkthrough

A material tour (eg Inbox from Google).
https://essetwide.github.io/material-walkthrough/
Apache License 2.0
32 stars 10 forks source link

Include the offsetParents when locating the target element's position. #42

Open woodcoder opened 6 years ago

woodcoder commented 6 years ago

This change totals up the offsetLeft and offsetTops of the target element and all its offsetParents to hopefully correctly locate elements that are inside fixed positioned elements, for example.

oliveirafilipe commented 6 years ago

@woodcoder Thank you Andy! We will make some tests and (hopefully) in few days give you a feedback. ping @menosprezzi

menosprezzi commented 6 years ago

@woodcoder Hello! Nice that you want work with us on it! Analysing your PR here. Do you have tested with our dist/demo.html code? In that HTML, we test the many ways that we use the plugin. We'll work on an E2E tests soon.

menosprezzi commented 6 years ago

In the second case of demo.html, it causes:

screen shot 2018-03-24 at 18 58 23
woodcoder commented 6 years ago

Hi @menosprezzi

Thanks for the library!

I'm sorry I didn't see the test page -- I've now looked and you're right the last commit fails in the way you show. Interestingly my original PR commit 6a1c0a1 is fine with these tests.

My final commit was to fix an issue with a translate3d transformed element in my local project, but it's obviously breaking other situations so I've reverted that commit.

woodcoder commented 6 years ago

I added a test that's similar to the situation in my local project and pushed a fix that seems to work for this and all the other tests (I wasn't taking into account the scrollY position).

menosprezzi commented 6 years ago

Wow. Right, we have problems. In the ~stable~ v2 at the repo, the demo.html runs fine in all the cases but not in elements positioned relatively in fixed parents, I understand it now! @woodcoder I'll analyse another way to calc the Y position with your points.