search

esskar / vscode-flutter-i18n-json

VS Code extension to create a binding between your translations from .json files and your Flutter app.
92 stars 22 forks source link

Supports multiple variables and ${} expression. #1

Closed lacti closed 5 years ago

lacti commented 5 years ago

Thanks for this great tools! This help me to make a flutter product very efficient.

But in my use cases, there are two problems about building variable names in i18n strings.

  1. It cannot support multiple variables. I think it is a bug in parseVariables function.
  2. It cannot support a variable without a space within a string like {minute}minutes. It leads to be String get remainTimes(String minute) => "$minuteminutes"; I think it can be fixed to add {} characters around this variable syntax.

If you do not mind, I am going to modify this and send a pull request.

esskar commented 5 years ago

Wow, thanks @lacti for your comment, suggestion and pull request. It's merged and will be pushed and published soon.

esskar commented 5 years ago

I just published a new version to the market place. thanks for your distribution. it was really appreciated.