search

estafette / estafette-k8s-hpa-scaler

Kubernetes controller to set minimum replicas from a Prometheus query on annotated HorizontalPodAutoscalers to avoid collapsing deployments in case of errors
https://helm.estafette.io
MIT License
10 stars 6 forks source link

Update apiversion #19

Closed markvincze closed 3 years ago

markvincze commented 3 years ago

The apiVersion extensions/v1beta1 was deprecated in 1.16: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

This PR updates the k8s client SDK we're using to its latest version, and changes the apiVersions.

JorritSalverda commented 3 years ago

I think we should switch to k8s.io/client-go/, since it's maintained by the Kubernetes community. Most estafette controllers have already made the switch.

markvincze commented 3 years ago

@JorritSalverda I'll check that.

markvincze commented 3 years ago

@JorritSalverda I've migrated it to the official k8s client. (Hope didn't make any mistakes, I couldn't fully test locally, I'll finish the testing in the clusters.)

markvincze commented 3 years ago

@JorritSalverda Could you merge it when you'll have a minute? (I don't have merge permissions)