search

estahn / k8s-image-swapper

Mirror images into your own registry and swap image references automatically.
https://estahn.github.io/k8s-image-swapper/
MIT License
523 stars 41 forks source link

dryRun and --dry-run does not seem to work as expected #129

Open haghabozorgi opened 2 years ago

haghabozorgi commented 2 years ago

We are testing the image swapper and have deployed it to our eks cluster, and the dryRun flag does not seem to be working (the actions are still taken; repo is created, image is uploaded, image ref is updated).

When we set the helm chart with 

config:
  dryRun: true
  logLevel: debug
  logFormat: console

and/or set --dry-run=true as arg in deployment spec the actions are still executed.

estahn commented 2 years ago

@haghabozorgi Are you still having this issue? Can you export the k8s-image-swapper configmap and add it?

mimmus commented 1 year ago

Yes, I can confirm: --dry-run is ineffective