search

estarriolvetch / ERC721Psi

MIT License
117 stars 29 forks source link

Compilation problem #47

Open YannSuissa opened 3 days ago

YannSuissa commented 3 days ago

Hi, I'm trying to use ERC721psi, but i have compilation errors :

----- Starting on network : localhost ------

Solidity 0.8.20 is not fully supported yet. You can still use Hardhat, but some features, like stack traces, might not work correctly.

Learn more at https://hardhat.org/hardhat-runner/docs/reference/solidity-support

TypeError: Member "isContract" not found or not visible after argument-dependent lookup in address. --> erc721psi/contracts/ERC721Psi.sol:467:13: | 467 | if (to.isContract()) { | ^^^^^^^^^^^^^

Error HH600: Compilation failed

I have to use solidity 0.8.20 to use the actual openzepplin.

Thanks for help Yann

YannSuissa commented 2 days ago

Ok, I've checked, it seems that isContract is deprecated : https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3682

The solution is to do : address(...).code.length > 0 I need to do many tests before then I'll do a PR if I succeed

YannSuissa commented 2 days ago

I just saw that you have a "in progress" branch with this change... Will there be a release of the 0.8 ?