It's been bugging me that we have such a confusing constructor.
Some of it got moved to Rets::HttpClient
I tried to clean up where we refer to instance variables with attr_readers within the class (sometimes we would refer to them as self.foo,@foo or foo).
I removed the attr_writer and allowed those arguments to be passed into the constructor.
The only instance var I left that confuses me is @tries which appears to be some now-defunct code which I would be in favour of deleting.
It's been bugging me that we have such a confusing constructor.
Some of it got moved to
Rets::HttpClientI tried to clean up where we refer to instance variables with attr_readers within the class (sometimes we would refer to them as
self.foo,@fooorfoo).I removed the attr_writer and allowed those arguments to be passed into the constructor.
The only instance var I left that confuses me is
@trieswhich appears to be some now-defunct code which I would be in favour of deleting.