estately / rets

A pure-ruby library for fetching data from RETS servers
https://github.com/estately/rets
127 stars 94 forks source link

Dont send unset params #147

Closed hfaulds closed 9 years ago

hfaulds commented 9 years ago

https://github.com/estately/rets/pull/142 meant we were now sending blank params to RETS servers.

A whole bunch of the mlses we integrate with did not like that (we were seeing a message along the lines of unknown value for StandardNames).

We could add sane defaults but I prefer to leave that to their RETS server. Especially as I'm also a tad nervous that some options might have been added in later versions of RETS (although haven't looked through the different specs to confirm).

This is pulled out of https://github.com/estately/rets/pull/98 as that's what we're testing in production at the moment.