search

estately / rets

A pure-ruby library for fetching data from RETS servers
https://github.com/estately/rets
127 stars 94 forks source link

pull out multi lookup table #150

Closed hfaulds closed 8 years ago

hfaulds commented 9 years ago

Whilst refactoring the metadata classes it became apparent to me that these are two separate classes.

This was reinforced when I was testing and wanted to create a MultiLookupTable (currently you have to provide the right value in the fragment hash)

phiggins commented 9 years ago

Aside from the amount of code duplicated between the two, this seems like a good change to me. :+1:

dougcole commented 8 years ago

@hfaulds do you want to clean up the merge conflict in this?

dougcole commented 8 years ago

nevermind, it was a simple one to fix. Looks good!