Revert "Fixes inversed 'no records found' behaviour"

estately / rets

A pure-ruby library for fetching data from RETS servers

https://github.com/estately/rets

127 stars 94 forks source link

Closed hfaulds closed 9 years ago

hfaulds commented 9 years ago

Reverts estately/rets#152

This is failing a bunch of tests. Sorry @ivar

Reading through the tests. Upon receiving NoRecordsFound:

If no_records_not_an_error is truthy then we don't retry or raise an exception and return 0 or [](depending if the query is a count query)
if no_records_not_an_error is falsey (default) then we retry and eventually raise an exception after X retries

phiggins commented 9 years ago

@hfaulds How come we didn't see the failures ahead of time? Does CI not run against PRs from non-collaborators or something?

dougcole commented 9 years ago

@phiggins exactly, travis-ci only runs against our repo. We need to be sure to run tests locally when merging pull requests.