search

estately / rets

A pure-ruby library for fetching data from RETS servers
https://github.com/estately/rets
127 stars 94 forks source link

strip trailing whitespace from lookup types #194

Closed hfaulds closed 8 years ago

hfaulds commented 8 years ago

We're experiencing an issue in one mls where they have trailing whitespace on these values.

We already strip trailing whitespace from values in our codebase and then we fail to resolve them to long values.

This could be put behind a bit of config but I'm struggling to see any scenario where this would be bad idea.

phiggins commented 8 years ago

LGTM :+1:, but CI is not happy.

hfaulds commented 8 years ago

Hmm, travis appears to have been complaining that our gemspec and Gemfile mocha versions differed. I updated the gemspec and Rakefile versions to match the Gemfile which fixed the CI build but I'm not sure of the greater implications of this or why I had to make this change.

hfaulds commented 8 years ago

I need to investigate how this will affect other mlses we're using before we merge this.

hfaulds commented 8 years ago

This affects ~10 of the mlses we integrate with at varying levels of severity. For some lookup tables it affects 1 lookup type such that it never resolves properly whereas others it affects far more.

I investigated a few places where this was affecting us and could only find instances of this PR fixing things.

When using COMPACT-DECODED this change won't affect anything.

dougcole commented 8 years ago

Thanks @hfaulds!