search

estately / rets

A pure-ruby library for fetching data from RETS servers
https://github.com/estately/rets
127 stars 94 forks source link

Update capability #200

Closed jeffgran closed 7 years ago

jeffgran commented 7 years ago

Hello estately/rets maintainers -- I am interested in adding Update functionality to this rets library.

At my company I have a (not-quite-immediate) need for this functionality and would like to start working on this in the coming weeks/months. It seems logical to add it to your existing gem rather than to start from scratch.

I am wondering if you have any input on this. Would you be open to accepting a pull request, assuming there are tests and that it conforms to the conventions of the existing ruby API? Do you have any thoughts about how this should work before I dive in?

Thanks for any feedback.

dougcole commented 7 years ago

Hey @jeffgran, thanks for the interest! I've never used the Update functionality of rets, but that seems like a reasonable thing to add. I'd ask that you write pretty thorough tests for it, otherwise I'd be pretty worried about breaking it as it's not something we use and I wouldn't be able to manually test it.

dougcole commented 7 years ago

Closing this now, feel free to re-open if you decide to pursue this and want to discuss it further.

jeffgran commented 7 years ago

OK. I am still working on it (slowly). I'll submit a pull request when I have something worthy of it.

dougcole commented 7 years ago

oh - great! Please do re-open as a pull request when you're ready, even if it's just as a work in progress, so I can give feedback as you go. I'd hate to see you do a ton of work and then have to rework it because I had concerns about the approach or something like that.

jeffgran commented 7 years ago

Will do. Right now I'm still in the proof-of-concept/experiment stage.