estately / rets

A pure-ruby library for fetching data from RETS servers
https://github.com/estately/rets
127 stars 94 forks source link

Retry behavior and 20403 response #79

Closed alexfarrill closed 9 years ago

alexfarrill commented 10 years ago

It doesn't seem correct that when receiving a reply code "20403" -- "No Object Found" that the request should be retried two more times. Would it be safe to skip retrying in this case?

dougcole commented 10 years ago

I agree - do you want to submit a pull request?

alexfarrill commented 10 years ago

Sure

hfaulds commented 9 years ago

Here's an example of one way you could implement this: https://github.com/estately/rets/pull/84

dougcole commented 9 years ago

OK, this is a new option added in #84, for now it defaults to still raising an error for backwards compatibility, but that will likely be changed in future releases, for now just set the option :no_records_not_an_error => true when you call find.