estately / rets

A pure-ruby library for fetching data from RETS servers
https://github.com/estately/rets
127 stars 94 forks source link

Workaround bogus http 401 in login method call #85

Closed tdtran closed 9 years ago

tdtran commented 9 years ago

Some RETS servers return success code in XML body but failure code 4xx in http status. We already have a workaround for it in Client::ErrorChecker#check

https://github.com/estately/rets/blob/master/lib/rets/client.rb#L356

But we forgot to use it in Client#login method. This PR rectifies it.

tcrayford commented 9 years ago

I assume you grepped the codebase to see if we do this anywhere else silly?

tdtran commented 9 years ago

I did grep for status_code. Seems ok now.