Feature: Namespace refactor to `RubyStatistics`

estebanz01 / ruby-statistics

Ruby gem for some statistical operations without any statistical language dependency

MIT License

109 stars 16 forks source link

Feature: Namespace refactor to `RubyStatistics` #120

Closed jasoncaryallen closed 8 months ago

jasoncaryallen commented 10 months ago

This PR:

updates paths throughout the gem from statistics/ to ruby-statistics
updates namespace throughout the gem from Statistics to RubyStatistics
Semantic Version bump to 4.0.0 as it is a breaking namespace change for apps already using ruby-statistics gem

Great work on this gem! I hope this contribution helps! Closes Issue #10

estebanz01 commented 10 months ago

Hola! 👋 thank you so much for your contribution! Highly appreciated !

I'll take a proper look today and hopefully get it merged with a new version released.

jasoncaryallen commented 10 months ago

Hola! 👋 thank you so much for your contribution! Highly appreciated !

I'll take a proper look today and hopefully get it merged with a new version released.

I think I forgot a few updates in the README, but otherwise it should be functionally correct and working in the new namespace. Will have another commit shortly. Cheers!

estebanz01 commented 8 months ago

@jasoncaryallen if you have time, can you rebase your branch with latest master? it should solve the conflicts that I caused myself by merging a PR that I had to revert 😬

jasoncaryallen commented 8 months ago

@jasoncaryallen if you have time, can you rebase your branch with latest master? it should solve the conflicts that I caused myself by merging a PR that I had to revert 😬

Can do. I’ll try to get to it this evening if possible!

jasoncaryallen commented 8 months ago

@estebanz01 - Namespace refactor should be good to go now. Rebased off the main branch and specs are all passing locally and on CI. Please ping me if any additional work is required, or ship it! 🚀 Thanks for maintaining this gem ❤️