Upgrade for rest-framework 3.X

estebistec commented 9 years ago

Here we go. Lots of code gets deleted (always good). The remaining types are so little that perhaps we can convince of their inclusion in rest-framework. CC: @tomchristie

I've kept the tests of list/dict fields to show that the DRF composite types meet the definition that users of this library had relied on.

There is one remaining failing test:

    def test_invalid_item():
        """
        When given an invalid value the ListOrItemField validate method should raise a ValidationError.
        """
        field = ListOrItemField(child=CharField(max_length=5))
        with pytest.raises(ValidationError):
>           field.to_internal_value('123456')
E           Failed: DID NOT RAISE

Whereas the test of a list with items of the wrong length does get the expected validation error. This is the case for any child types that I happened to try. For whatever reason, the validation only kicked in when the child of a ListField. This also gets no validation error:

CharField(max_length=5).to_internal_value('123456')

kevin-brown commented 9 years ago

You never updated the requirements.txt, so none of the tests were able to run.

estebistec commented 9 years ago

derp, updated. I was working out of setup.py when I tested the upgrade.

estebistec commented 9 years ago

Yes, now exactly the one test that I expect fails.

vperron commented 8 years ago

Any news on this ?

tomchristie commented 8 years ago

@vperron Some of this is supported in REST framework these days (ListField, DictField)

vperron commented 8 years ago

Hi @tomchristie , actually I was interested in ListOrItemField for returning data back from ElasticSearch, which transparently handles collections or single objects (https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html)

vperron commented 8 years ago

I must admit I have no clue how to fix the ValidationError just yet. Did anyone find something about that ?

vperron commented 8 years ago

Here is the fix I think I'll be using:


    def to_internal_value(self, data):
        if isinstance(data, list):
            return self.list_field.to_internal_value(data)
        # Force field validation. Not necessary on the list_field since DRF calls it recursively.
        self.item_field.run_validation(data)
        return self.item_field.to_internal_value(data)

Does it seem valid enough ?