search

estebistec / drf-compound-fields

Django-REST-framework serializer fields for compound types.
BSD 3-Clause "New" or "Revised" License
92 stars 12 forks source link

Init commit for PartialDictField #9

Closed sonnyhu closed 10 years ago

sonnyhu commented 10 years ago

Pull request for issue #8

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-2.67%) when pulling 1b4a3173b2fdee497c427f3ed32e3e9d1c032391 on SonnyHu:partial-dict-field into 6aa85952f6c7350fcf85bda2f75fbc3e8ecf9783 on estebistec:master.

sonnyhu commented 10 years ago

Thanks! Just checked in this change.

sonnyhu commented 10 years ago

@estebistec hey, I think this is ready on my side.

estebistec commented 10 years ago

Hey, sorry for the lack of responsiveness. Over on one of my own pulls I'm trying to resolve some issues with error collection, and I can't really work on it during the day right now. As soon as I get that merged I'll pull your code in. I do appreciate the pull! :P

sonnyhu commented 10 years ago

Thanks. not mean to push. I thought I need to say "it is done" otherwise you might thought I was still working on this :)

estebistec commented 10 years ago

Yeah, I didn't think you were pushing :P I just want to keep up communication on contribution requests

estebistec commented 10 years ago

Oh, also, one last update to this pull request: add yourself to contributors :P

https://github.com/estebistec/drf-compound-fields/blob/master/AUTHORS.rst

sonnyhu commented 10 years ago

Done. Thanks!

estebistec commented 10 years ago

Okay, now that I'm done with #7 , do you mind doing a rebase? Once it's merge-able I'll get it in.

sonnyhu commented 10 years ago

Done. Thanks!

estebistec commented 10 years ago

nice, that was fast :P