esteinig / nanoq

Minimal but speedy quality control for nanopore reads in Rust :bear:
MIT License
109 stars 9 forks source link

[JOSS Review] Code quality comment #18

Closed natir closed 2 years ago

natir commented 3 years ago

This relates to my JOSS review openjournals/joss-reviews#2991

First thanks for your work on this tools and publications

Some comments about code quality:

esteinig commented 3 years ago

Again, some comments before working on the joss branch:

  1. Yep can implement some CI (I think)
  2. Oh cool, thanks for the tip, will lint the code
  3. Yep will do!
esteinig commented 2 years ago

In regards to your points: