[JOSS Review] Other comments

esteinig / nanoq

Minimal but speedy quality control for nanopore reads in Rust :bear:

MIT License

109 stars 9 forks source link

Closed natir closed 2 years ago

natir commented 3 years ago

This relates to my JOSS review openjournals/joss-reviews#2991

First thanks for your work on this tools and publications

I put here the comments that I could not group with others:

[x] Link to nanopore documentation about quality score require login to nanopore website, can you provide another link ?
[x] Did you plan to replace your own conda by a bioconda recipe ? (I could do it for you)

esteinig commented 3 years ago

@natir thanks very much for your comments and improvements - in the other threads as well. I will work on this tonight :)

esteinig commented 3 years ago

Yes, good point! There was a discussion on this during development of Nanostat which might be relevant and not behind a community wall. Please let me know if this is appropriate: https://gigabaseorgigabyte.wordpress.com/2017/06/26/averaging-basecall-quality-scores-the-right-way/
Yes, absolutely. I will give it a shot but have had Michael's excellent help last time. I might have to come back to your generous offer

natir commented 3 years ago

it's ok
If you want you can take inspiration from my package yacrd or fpa don't hesitate to tag me in your bioconda pull request, I would review it with pleasure.

esteinig commented 3 years ago

thanks heaps, appreciate the help!