search

esterpantaleo / etymology

This repository contains code behind the visualization of the Wikimedia tool etytree at http://tools.wmflabs.org/etytree/
https://esterpantaleo.github.io/etymology/
50 stars 9 forks source link

function naming and potential overwrite #17

Closed xferguson closed 7 years ago

xferguson commented 7 years ago

it looks like we have the same function get() definition twice:

The first time is in the dagre-d3.js library, line 14764 (ish) Then again in load.js, at the bottom

This is probably leading to unintended side-effects, and we should change the load.js function name. Etytree calls the function to assign the return value to const source.

esterpantaleo commented 7 years ago

how about I rename function get "getXMLHttpRequest"?

xferguson commented 7 years ago

That sounds reasonable. I might recommend merging pull request #18 first, as it has the lint information in place for the get function.