estesp / manifest-tool

Command line tool to create and query container image manifest list/indexes
Apache License 2.0
741 stars 92 forks source link

restore option to set manifest type to OCI or Docker #181

Closed deitch closed 2 years ago

deitch commented 2 years ago

Fixes #180 (which apparently was my fault in the first place).

I added it as another option to registry.PushManifestList(), and then used the previous "type" flag in the two places in the CLI that call it.

deitch commented 2 years ago

How odd. It says "3 successful, 1 cancelled, and 1 in progress", but I cannot see any it cancelled that "macOS CI Linters" check. The email I got said DCO failed, which is even odder. What am I doing wrong?

deitch commented 2 years ago

I ran linters locally, looks fine 🤷‍♂️

estesp commented 2 years ago

I just restarted failed tests and it happened again; GH Actions glitch--I'll run them again in a bit. Nothing looks wrong at all and it passed DCO in Actions CI.

estesp commented 2 years ago

Might be hitting a speed bump with 10.15 availability given it is about to be deprecated in Actions; #182 seems to be working properly. I'll merge and then you can rebase.

estesp commented 2 years ago

Ah! We're in one of the time windows where you get temporary failures to remind you to upgrade :) https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/

182 is merged; you can rebase to get a clean run

deitch commented 2 years ago

Nice. CI is all green now. Back at you @estesp

tianon commented 1 year ago

@estesp can I somehow bribe you to make a new release with this fix? :innocent:

estesp commented 1 year ago

awww, bummer. It was on a todo list that .. the dog ate, or something like that. Seriously had meant to do a quick point release and never did :( Will queue it up for this week!

estesp commented 1 year ago

@tianon done! https://github.com/estesp/manifest-tool/releases/tag/v2.0.6

tianon commented 1 year ago

Thank you!!! :heart: