estesp / manifest-tool

Command line tool to create and query container image manifest list/indexes
Apache License 2.0
737 stars 92 forks source link

fix(Dockerfile.alpine): gcloud auth naming and targetarch from alpine #236

Closed keg closed 9 months ago

keg commented 9 months ago

Hello, thanks for creating this tool. It's been helpful for our CI/CD processes.

I am submitted this PR with two fixes that we found helpful.

Example docker config:

{
  "auths": {},
  "credsStore": "desktop",
  "credHelpers": {
    "asia.gcr.io": "gcloud",
    "eu.gcr.io": "gcloud",
    "gcr.io": "gcloud",
    "marketplace.gcr.io": "gcloud",
    "staging-k8s.gcr.io": "gcloud",
    "us.gcr.io": "gcloud",
  },
  "currentContext": "desktop-linux"
}
estesp commented 9 months ago

Thanks so much! Good to hear the tool is useful for you. Changes look totally reasonable, but can you sign your commit with a Signed-off-by: line for the DCO check?

keg commented 9 months ago

Thanks for the contribution!

Thank you and thanks for the speedy merge!