estevaocm / bitkey

A self-contained read-only CD/USB stick with everything you need to perform highly secure air-gapped Bitcoin transactions. Offline cold storage made (slightly more) practical.
https://bitkey.io
23 stars 9 forks source link

Build fixed (electrum-dash icon) and Exodus Update #32

Closed emartec closed 6 years ago

emartec commented 6 years ago

I had a problem with the build. A line related to the electrum-dash icon was not working, and simply removing it fixed it all. The icon is present.

BTW, Electrum-dash execution fail. It says something like "module not found: dns". I'll create an issue.

estevaocm commented 6 years ago

Thanks. Electrum-Dash issue is logged in #26

emartec commented 6 years ago

I don't understand.... How the "failed to execute" issue of electrum-dash is related to the vulnerability issue of issue #26 ?

estevaocm commented 6 years ago

My last comment there was: "Electrum-Dash has been upgraded to solve the reported vulnerability, but is broken for lack of dependencies."

I have not succeeded in compiling the latest Electrum-Dash with Python in Bitkey, and decided not to downgrade due to the security issue. I asked the developer to package the dependencies as the other Electrum variants do, but had no response yet.

estevaocm commented 6 years ago

https://github.com/akhavr/electrum-dash/issues/12

emartec commented 6 years ago

Ok, good!

estevaocm commented 6 years ago

To be honest, I have not invested much time fixing this dependency issue. I could use some help.

estevaocm commented 6 years ago

Just found a dependencies package from an older version in another rep. Will make an attempt to compile the new one with it.

estevaocm commented 6 years ago

It worked!

emartec commented 6 years ago

Excellent!