search

esteve / ros2_raspbian_tools

Tools for crosscompiling ROS2 for the Raspberry Pi
Apache License 2.0
46 stars 15 forks source link

Add pyparsing and fix keyserver #4

Closed russkel closed 6 years ago

russkel commented 6 years ago

Add pyparsing to the crosscompiler, otherwise ament doesn't even run. Keyserver changed because the old one fails quite often, this was a recommended replacement.

russkel commented 6 years ago

I have fixed the pull req as per your request :).

esteve commented 6 years ago

@russkel thanks!

esteve commented 6 years ago

@russkel I just realized after merging this PR that you moved the apt -y upgrade instead of removing it. Sorry I wasn't clearer in my review comment, I meant that by adding apt -y upgrade, it'd make the on-disk size of the image larger. I've reverted the apt -y upgrade change in master, but kept all the other changes you made.

russkel commented 6 years ago

Apologies, that was a change of mine that wasn't stashed for some reason. I didn't notice it was included after removing the other line!

Thanks for merging.