esthor / overcast-electron-app

A simple overcast.fm podcast app for mac and Linux
12 stars 0 forks source link

Menu bar #1

Open nihaals opened 6 years ago

nihaals commented 6 years ago

Are you able to have it show up in your menu bar for easy access to the podcast controls? This is already implemented in https://github.com/insidegui/PodcastMenu and having this would make it the perfect podcast player, especially if ported to Windows (which has its own menu bar but also it's own media controls when you are hovering over a window).

MichaelDimmitt commented 6 years ago

possible. :)

@esthor, okay if I take a stab at this on monday? I could make a release that is for the menubar. Then you could have both releases in the readme for a user to install.

I will post updates on the progress whether an easy fix or no. And give a timeline as I dive further into the code base. But it should be less than two days. Shooting for next Sunday Completion.

Cheers, Michael Dimmitt

esthor commented 6 years ago

@MichaelDimmitt Sounds like a great idea!

nihaals commented 6 years ago

Also, does the Overcast licence allow you to do any formatting to the page? If yes, then the menu bar might have to be modified slightly so it works and looks better than just having the entire page open with some things cropped.

MichaelDimmitt commented 6 years ago

@OrangutanGaming, if you can make a picture of the changes you want. On a napkin or with photoshop/sketch. I can take a look at incorporating these styling changes. 😋

MichaelDimmitt commented 6 years ago

@OrangutanGaming, @esthor, let me know what you two think, release, click to download menubar

I made the change on the repo below; had to do it the normal way instead of nativefier (less dependency overhead). I added the diff that went into implementing that specific website.

https://github.com/osx-menubar-project/js_menubar_Dynamic_Wallpaper/commit/ea86802a4b921eff600937d8a9365f577623347f - [diff]

Next step is to have it running as a background process with a launch agent. Which wont take long. @OrangutanGaming, are you using a mac computer?

MichaelDimmitt commented 6 years ago

Here is a preliminary example

ocast_example

nihaals commented 6 years ago

Will they both need to be logged in separately or will it display the same? So if you started playing something on the main app then go into the menu bar, will it show the same page and progress? Also, are you able to make the icon this (fits the normal scheme, although needs to be black/grey like other icons)

MichaelDimmitt commented 6 years ago

I updated the logo for the menubar. click here to download updated binary screen shot 2018-08-21 at 12 45 49 pm

nihaals commented 6 years ago

So you aren't able to use a black version of the logo?

MichaelDimmitt commented 6 years ago

@OrangutanGaming, post the black version I am unaware of the logo you are mentioning.

nihaals commented 6 years ago

It didn't already exist, but just made one logo

MichaelDimmitt commented 6 years ago

@OrangutanGaming, something like this? screen shot 2018-08-21 at 3 27 32 pm

nihaals commented 6 years ago

Hmm, not sure why it still doesn't completely fit in with other icons, perhaps it's slightly too thick? It's a fairly minor issue which I guess can be changed later.

MichaelDimmitt commented 6 years ago

@OrangutanGaming, I can fix that pretty easy. But it is on the right track?

nihaals commented 6 years ago

Well it also looks like other icons aren't completely black, but it's hard to tell.

MichaelDimmitt commented 6 years ago

See updated picture below: believe thats the closest were going to get. dimensions 16x18 pixels.

screen shot 2018-08-21 at 3 42 15 pm

nihaals commented 6 years ago

Does it look slightly off to you?

MichaelDimmitt commented 6 years ago

@OrangutanGaming, the image you gave me is 3334 × 3334 If you want it to match the other icons it needs to be 16x18 So if you could change the image to be 2963.555 x 3334 or 3334 x 3704.444.

Then it will not look slightly off when I shrink it down. I do not think it makes a noticeable difference and think it looks better with color (orange). However, happy to make additional changes.

nihaals commented 6 years ago

Well it's just that I feel like it doesn't quite fit in with other icons on my menu bar. There's quite a consistent style with most but work with the others. Are you able to use this?

MichaelDimmitt commented 6 years ago

@OrangutanGaming, is this better? screen shot 2018-08-21 at 4 09 22 pm

nihaals commented 6 years ago

The current version doesn't support using the normal window so it's menu bar only instead of both menu bar and normal window. Are you able to add it and have it share the same page?

MichaelDimmitt commented 6 years ago

@OrangutanGaming, I think that logo looks better in black 👍 screen shot 2018-08-21 at 4 20 42 pm

esthor commented 6 years ago

@MichaelDimmitt It's looking really good! Thanks for helping out so much with this project and user requests! 👍

nicgrayson commented 6 years ago

FYI: An overcast menubar already exists: https://github.com/insidegui/PodcastMenu

nihaals commented 6 years ago

This is already implemented in https://github.com/insidegui/PodcastMenu

I already said this in the original description