search

estiens / world_cup_json

Rails backend for a scraper that outputs World Cup data as JSON
928 stars 107 forks source link

Some incorrect goal events in matches #163

Closed nokyotsu closed 3 years ago

nokyotsu commented 5 years ago

For example the opening match of the 2019 Women's World Cup (fifa_id: 300438238), France won 4-0 against South Korea; but there are 6 goal events in home_team_events.

So far I found all of these discrepancies:

Incorrect score for FRA from team events: expected 4 got 6 (match id: 300438238)
Incorrect score for NOR from team events: expected 3 got 2 (match id: 300438213)
Incorrect score for NGA from team events: expected 2 got 1 (match id: 300438222)
Incorrect score for NOR from team events: expected 1 got 0 (match id: 300438220)
Incorrect score for BRA from team events: expected 2 got 3 (match id: 300438225)
Incorrect score for ENG from team events: expected 1 got 2 (match id: 300438223)
Incorrect score for ENG from team events: expected 2 got 3 (match id: 300438233)
Incorrect score for CMR from team events: expected 2 got 3 (match id: 300438239)
Incorrect score for NZL from team events: expected 1 got 0 (match id: 300438239)
Incorrect score for CHI from team events: expected 2 got 1 (match id: 300438246)
estiens commented 5 years ago

Thanks - I'll look into it! This often happens when a goal is corrected after the fact to a different scorer, etc. The score method should always be correct, but events can be weird