estiens / world_cup_json

Rails backend for a scraper that outputs World Cup data as JSON
928 stars 107 forks source link

Winner fields missing for MAR - ESP knockout game. #238

Closed andyewen closed 1 year ago

andyewen commented 1 year ago

Getting this in the response from the /matches endpoint.

{
  "id": 55,
  "venue": "Education City Stadium",
  "location": "Doha",
  "status": "completed",
  "attendance": "44667",
  "stage_name": "Round of 16",
  "home_team_country": "MAR",
  "away_team_country": "ESP",
  "datetime": "2022-12-06T15:00:00Z",
  "winner": null,
  "winner_code": null,
  "home_team": {
    "country": "MAR",
    "name": "Morocco",
    "goals": 0,
    "penalties": 3
  },
  "away_team": {
    "country": "ESP",
    "name": "Spain",
    "goals": 0,
    "penalties": 0
  },
  "last_checked_at": "2022-12-06T21:12:03Z",
  "last_changed_at": "2022-12-06T21:12:03Z"
}

goals and penalties are correct and the match status is "completed" but the winner and winner_code fields aren't populated. Could this be an issue with the scraper?

jgarcianewemage commented 1 year ago

MAR - POR match's labels not updated also

estiens commented 1 year ago

Thanks, should be fixed now with an extra cleanup job to go back and fixup if combo of conditions leaves a match in a completed and final state without a winner

andyewen commented 1 year ago

Thanks!

jgarcianewemage commented 1 year ago

now missing first quarter final match CRO v ARG