estivo / Instantfox

Instantfox Quick Search » Firefox Add-On for a smart address bar
http://www.instantfox.net
GNU General Public License v2.0
59 stars 11 forks source link

most of the favicons are missing #106

Open kinlong322 opened 9 years ago

kinlong322 commented 9 years ago

for example, the generated iconURI is: "iconURI": "http://www.google.com/s2/favicons?domain=http://techcrunch.com/search/%q" this resulted in Bad request Error 400.

Instead, the query string of the iconURI should be trimmed off, leaving just the domain name for correctly fetching icon: http://www.google.com/s2/favicons?domain=http://techcrunch.com/

Thank you for this great add-on. I use it all the time.

Drugoy commented 9 years ago

Why not use the url to the site's icon? http://techcrunch.com/favicon.ico

fix-fix commented 9 years ago

@Drugoy because some websites don't use /favicon.ico scheme, e.g.: https://instagram.com/favicon.ico

algkmn commented 9 years ago

@fix-fix https://instagramstatic-a.akamaihd.net/bluebar/5ba3356/images/ico/favicon.ico

fix-fix commented 9 years ago

@algkmn I know they have some favicon somewhere. I was speaking about '/favicon.ico' scheme not being the universal approach, therefore this project should depend on external favicon service.

iakoboss7 commented 9 years ago

any chance this will get fixed?