search

estivo / Instantfox

Instantfox Quick Search » Firefox Add-On for a smart address bar
http://www.instantfox.net
GNU General Public License v2.0
59 stars 11 forks source link

Suggestion popup is broken in FF41.0 #115

Closed FatOrangutan closed 8 years ago

FatOrangutan commented 8 years ago

In Firefox 41.0 (now stable), the text of the suggestions in the URL bar suggestion popup is invisible. The icon next to it is visible, and if I use the arrow keys to get to a suggestion, I can see the suggestion's preview in the URL bar. This leads me to think that the addon is fetching the search results fine, just that the results displayed aren't visible. Here's a picture: capture I had only types 'moz,' used the down arrow key to the get to the second option, and InstantFox updated the URL bar to show 'mozilla firefox.' All this is expected of course, except that the suggestions are themselves invisible.

Does anybody have a fix? Thanks.

alpaca-power commented 8 years ago

sometimes the suggestion dropdown doesn't show altogether. 20150924221730

FeBe95 commented 8 years ago

I can confirm that, and all in all the add-on is very buggy. Is someone working on this project at the moment?

BobVul commented 8 years ago

I've fixed this and created a pull request. Last time it took them one week to notice/approve it, so I guess we'll just wait now.

I've packaged the fixed version here if you don't want to wait, but it won't work on FF43+ because it's unverified, and I don't know if it'll correctly auto-update when the official release catches up (it should).

BobVul commented 8 years ago

As for the other bugs (@FeBe95), I intend to take a look at the mouse click and missing last character bugs at some point (when time permits), but they don't affect me much so they're rather low-priority - and it's not my project anyway. Looks like the maintainer has been fairly inactive for the last few years. Pity.

FatOrangutan commented 8 years ago

Thank you for the fix. There is one issue however: sometimes, the URL of the 1st suggestion gets displayed too. For instance, here I had just typed 'wiki': [ignore the different search icon, it is the only change I made to your xpi] capture

BobVul commented 8 years ago

Hm. That's interesting, but the only change I made was to resolve a JS syntax error - the logic has not changed. It looks like that's intended to mark the URL navigated to by the instant feature, implemented late last year: https://github.com/estivo/Instantfox/commit/c1a7ae85687040526685967ceb29d57f6a9656b1 https://github.com/estivo/Instantfox/commit/2e49a64cc218ca613128634df25151ed0d29e5c5

FeBe95 commented 8 years ago

@Elusive138 Okay, thanks for the fix and the effort you made! Nice to hear that you intend to take a look at the other issues. They persist for such a long time now, I got used to adding a whitespace at the end of each query and I disabled nearly all instant-page-loadings. Also I am rarely using a click to confirm a search, so that's okay with me.

FatOrangutan commented 8 years ago

@Elusive138 I just tried it on a clean profile and can reproduce it reliably: Just type in 'wiki' - the suggestions look all good, but give it a second and it appends an URL to the first entry. Just sometimes, I would have URL's appended to the second and third entries too. For what it's worth, fix-fix's version from here [https://github.com/fix-fix/Instantfox/releases/tag/v3.0.1-beta.3] doesn't seem to have this issue. Anyways, thank you for your work on this. The other day I went through AMO trying all similar extensions and realizing none of them are as good as InstantFox. Your work to keep this usable is truly appreciated.

Instantfox commented 8 years ago

use build menu item from instantfox devel button menu to build a version that doesn't have under experimental features enabled. You might need https://addons.mozilla.org/en-US/firefox/addon/the-addon-bar/ installed to see instantfox devel button

BobVul commented 8 years ago

@Instantfox Thanks, I wasn't aware of that menu. I've updated the patch release (same link). And thanks for fixing the other major (mouse-click, last-character) issues! :)

amaru7 commented 8 years ago

@Elusive138 Really happy that you came back, I never got a reply from you on E-Mailing that issue, so I was afraid you abandoned the add on. Meanwhile I tried omnibar but I didn't like it as much as Instantfox.

A little bug I found is the autocomplete, when I get a suggestion for autocomplete and press the right button, it makes a double letter.

For instanse I enter "g wiki (it suggests pedia, I press right and then it is wikiipedia with double the letter "i".

Anyway happy you took the time to update and all I can do is thank you for your time to continue this add on which is one of my absolute favourites.

BobVul commented 8 years ago

@amaru7 You have the wrong person - @Instantfox is the dev/maintainer for this addon. I'm just some random guy with a PR now and then.

Darkvar commented 8 years ago

@Instantfox , @Elusive138 , hey guys. I'm just curious - was the updated version already released ? I can observe exactly the same issue with my FF 41.0.1 and InstantFox addon 3.0.0.1-signed.

MarkCheshire commented 8 years ago

It would be really cool to get this upgrade out. Search is so much more painful without InstantFox working perfectly.

fix-fix commented 8 years ago

@MarkCheshire you can download version with this bug fixed on my releases page. Unfortunately it's not signed, so it will stop to work in Firefox 44, but I think @Instantfox will come with solution to the situation.

MarkCheshire commented 8 years ago

Great news today I got upgraded to 3.0.2 and the problem appears fixed

Metal-Mighty commented 8 years ago

Same here!

MarcoRemy commented 8 years ago

Will this issue get fixed soon? Is this extension alive yet?

fix-fix commented 8 years ago

@NyroTheCat are you using the 3.0.2 version?

MarcoRemy commented 8 years ago

oh i'm sorry. my extension just got updated :) waited a long time for this fix

great +1

fix-fix commented 8 years ago

Fixed in the most recent release (3.0.2)