estivo / Instantfox

Instantfox Quick Search » Firefox Add-On for a smart address bar
http://www.instantfox.net
GNU General Public License v2.0
59 stars 11 forks source link

Fix result rendering in FF41+ #118

Closed BobVul closed 8 years ago

BobVul commented 8 years ago

This fixes issue #115.

Seems that FF41 removed expression closures, at least in this context.

Note that these are still used in other places, e.g. instantfoxModule.js:980. This might break in the future - it would be a good idea to convert them to arrow functions or traditional function expressions. Occurrences can be found with the regex function\s*\([^)]*\)\s*[^\s{] and the fix is easy - but that is beyond the scope of this PR.

fix-fix commented 8 years ago

Good job. Thanks for the fix. I applied this pull request to my fork as well. Users can grab it here