estivo / Instantfox

Instantfox Quick Search » Firefox Add-On for a smart address bar
http://www.instantfox.net
GNU General Public License v2.0
59 stars 11 forks source link

Mozilla review notices #45

Closed estivo closed 12 years ago

estivo commented 12 years ago

First Mail:

Date: Wed, 08 Feb 2012 23:02:57 -0000 A Mozilla Add-ons Editor requested further information from you regarding version 2.7.0 of your add-on InstantFox Quick Search.

Kris Maglione wrote:

"Hi there,

While our current policy is to allow eval-based textual mangling of builtin functions, I do not review such add-ons, and most other editors will avoid them, so unless you're incapable of finding an alternative, I suggest that you avoid doing so if at all possible. Please see https://developer.mozilla.org/en/XUL_School/Appendix_C:_Avoid_using_eval_in_Add-ons for more information.

Thanks."


a day later: (reviewed :blush:)

Date: Thu, 09 Feb 2012 17:07:16 -0000 Your add-on, InstantFox Quick Search 2.7.0, has been fully reviewed by an editor and is now available for download in our gallery at https://addons.mozilla.org/addon/instantfox/

Reviewer: Andrew Williamson

Comments: This version has been approved for the public.

Thank you!

Tested on Windows7 with Firefox11


btw. just found: Test Your Add-ons for Memory Leaks! @ http://blog.mozilla.com/addons/2012/02/09/add-ons-update-10/

nightwing commented 12 years ago

fixed in aaabe7e6166b7f50081f60d2c8f94330188b65d4

soon they will be using same technique to convert addons into jetpacks :(