estivo / Instantfox

Instantfox Quick Search » Firefox Add-On for a smart address bar
http://www.instantfox.net
GNU General Public License v2.0
59 stars 11 forks source link

google sometimes loses searchbox #47

Closed estivo closed 12 years ago

estivo commented 12 years ago

Some user report that sometimes Google forgets it's searchbox like here:

This mostly happens when using the native Google searchbox (not Instantfox)

I asked to get some proof + maybe video: http://dl.dropbox.com/u/12822196/instantfox-google-input-missing.mov

and try to get more details, soon!

nightwing commented 12 years ago

funny opening this url http://www.google.ru/#q="<% sometimes puts searchbox in the middle of the page and sometimes redirects to this http://www.google.am/search?q="<%

looks like google doesn't like searces with <

estivo commented 12 years ago

it should happen with normal keyword strings, too!

estivo commented 12 years ago

ok i can reproduce it sometimes → how to: 1.) search something + don't hit enter, but release the result by clicking somewhere on the page! 2.) go into the google box and change the search query

somehow like this http://dl.dropbox.com/u/12822196/if210212.mov


Bugreports e.g.

after the last update (of instantfox), many time google is not responding and request is not shown (the search field disappears)

by hr_haddad@yahoo.fr
Instantfox Version: 2.7.0
Sprache: fr,fr-fr;q=0.8,en-us;q=0.5,en;q=0.3
Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
196.203.244.26 - (196.203.244.26)
nightwing commented 12 years ago

a442363a32c324b8e0661522fcfa207001387067 fixes "deletes result" bug can't reproduce "spiegel ≠ spielaffe!" bug, can you give me log data from error console when this happens.

estivo commented 12 years ago

At the moment with a442363, the first click outside doesn't release the Google search (input)

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMHTMLInputElement.setSelectionRange]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: http://www.google.de/extern_js/f/CgJkZRICZGUrMEU4ACwrMFo4ACwrMA44ACwrMBc4ACwrMDw4ACwrMFE4ACwrMFk4ACwrMAo4AJoCAmNjLCswmAE4ACwrMBY4ACwrMBk4ACwrMCs4AJoCC2pzX3JlZGlyZWN0LCswQTgALCswTTgALCswTjgALCswUzgALCswVDgALCswaTgALCswkAE4ACwrMJIBOAAsKzCXATgALCswowE4ACwrMKcBOAAsKzDVATgALCsw2AE4ACwrMHQ4ACwrMB04ACwrMFw4ACwrMBg4ACwrMCY4ACyAAmaQAmU/pve-tJEgHa0.js :: <TOP_LEVEL> :: line 86"  data: no]
Source File: chrome://instantfox/content/contentHandler.js
Line: 110

On FF 13 Instantfox is somehow completely broken!?

nightwing commented 12 years ago

do you see this error in development or build mode? now i can see this in build mode on FF 13, but everything works fine?!

if you see this in development mode can you give me messages before the error as well, please (console2 have option to copy everything)

estivo commented 12 years ago

error happend in build mode...

Another one, which happend:

Fehler: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIAutoCompleteController.getImageAt]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/bindings/autocomplete.xml :: _appendCurrentResult :: line 1069"  data: no]

Summary:

issue still happens with a442363

Case 1

Case 2

to make a search I do these steps : g + some words + Enter

sometimes it's juste the search field who disappears and other times I have as a result a blank page

NOTE : I attached a screenshot I'm using LinuxMint12 (Ubuntu 11.10) and FF 10.0.2

Case 3

i just saw when searching "g something" + not hitting enter, but clicking somewhere on the Google page, it' doesn't release the url in the urlbar until i clicked again!


P.S: FF13 works for me now oO

nightwing commented 12 years ago

Case 3 seems like a linux bug. if dom is modified while popup is open next click is consumed by popup (hope i can find a workaround for this)

empty searchbox after searching for "hamburg" in https://github.com/estivo/Instantfox/issues/47#issuecomment-4085257 was easy instantfox was searching for "" on mouseup what happens in other cases is still mystery for me:(

estivo commented 12 years ago

what happens in other cases is still mystery for me:(

any detective clue how to get on to the track of this bug!? i can share the screen via teamviewer?

nightwing commented 12 years ago

how often do you see this kind of bug? and are there reports from windows users too? teamviewer would be very helpful in case this is platform specific (not very likely though)

i can make debug version, which will save all search history and logs about instantfox state to a file, if someone encounters this bug while using it, we'll have good chance to understand what's going on.

estivo commented 12 years ago

how often do you see this kind of bug?

quite often!

and are there reports from windows users too?

will check that.

i can make debug version, which will save all search history and logs about instantfox state to a file, if someone encounters this bug while using it, we'll have good chance to understand what's going on.

that would be great!

estivo commented 12 years ago

and are there reports from windows users too?

yes

nightwing commented 12 years ago

version with logging enabled https://github.com/downloads/estivo/Instantfox/firefox.xpi

use 'copy log data' from instantfox defeloper menu

estivo commented 12 years ago

broken with the last query: http://dl.dropbox.com/u/12822196/instantfoxbug.txt

estivo commented 12 years ago

note @ me: write Haddad an e-mail, when problem is fixed...

May be this is helpful for you : the problem no longer exists if I deactivate the "instant search" in google Haddad hr.haddad@gmail.com

estivo commented 12 years ago

@nightwing sorry about the delay! - today i am completely available! Ping me with a post here or via skype:johanwenz to post you the Teamviewer access

nightwing commented 12 years ago

Ping :)

estivo commented 12 years ago

Whops you caught me on lunch time ;) - it's Henrik's Computer, he can show you the issue as soon as you login... Feel free to work/test on his computer...

~~Teamviewer: ID: 456 081 273 Pass: 8318~~

Chat: Skype, an Issue or jolu@jabber.org !?

estivo commented 12 years ago

New connection:

Teamviewer: ID: 456 081 273 Pass: 4768

nightwing commented 12 years ago

can i install console2 and foximirror addons for debugging?

nightwing commented 12 years ago

this seems to be a conflict with 1password. which explains why bug happens for logged in users

estivo commented 12 years ago

tricky! chapeau! :blush: - a lot of mac user are using it!

Here we can find the extension: https://agilebits.com/extensions/mac/index.html?locale=en or here: http://dl.dropbox.com/u/12822196/1Password.xpi

nightwing commented 12 years ago

i can't reproduce this bug with attached extension not sure if it's my vm configuration or the version of extension (looks like it uses newer version of jetpack)

066c35dff29ab4c66c97ac241b8216226e76e4c7 should at least fix problem with instant not working for all engines please try this before updating 1password

estivo commented 12 years ago

did https://github.com/estivo/Instantfox/commit/066c35dff29ab4c66c97ac241b8216226e76e4c7 fix https://github.com/estivo/Instantfox/issues/47 i can't reproduce it on my computer.

yes, seems to be fixed! :)