Closed vladimirr9 closed 7 months ago
Can you add some test that verify that this doesn't happen again?
@bconn98 can you review this please?
@estk @vladimirr9 Can confirm the README was incorrect and now works as expected.
@vladimirr9 Are you able to add a test?
Not too experienced with rust. I see there's already a test to ensure the config is read properly and correct under src/config/raw.rs
.
This seems to have been a mismatch between documentation and what is actually valid input.
Don't know how I'd design a test to ensure that the documentation itself is correct.
Added a test that does readme parsing in order to get the config from there. Verify if it's OK and if the location is OK.
The test does indeed catch that the config in main is bad. However, it doesn't catch a couple other weird indentations I give it. Let me think on it.
The failure to capture the bad configs isn't your test lacking but the deserializer failing to capture. @estk IMO this deserves a followup issue to investigate and address.
New issue: https://github.com/estk/log4rs/issues/334
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ebb9123
) 61.12% compared to head (ed2f885
) 61.12%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
not sure how to resolve the lint stuff, @bconn98 , any ideas?
@estk we don’t have many markdown files. We could just reduce the spaces to 2 for markdown as well as yaml.
Sounds good to me.
@vladimirr9 Hey, can you resolve the rustfmt error by cleaning up the trailing whitespace? Also make the following change in .editorconfig
:
[*.md]
trim_trailing_whitespace = false
indent_size = 2
Made the changes.
@estk kick off a CI and then it should be all set
@vladimirr9 Actually looks like you need to rebase main in
Rebased
Fails parsing the current config. Seems to have been changed accidentally as it doesn't make sense that root and logger are defined within appenders.