estk / log4rs

A highly configurable logging framework for Rust
Apache License 2.0
998 stars 147 forks source link

Add support for CompositeTrigger #342

Open Dirreke opened 8 months ago

Dirreke commented 8 months ago

This is a BREAKING change.

This will support CompositeTriggerPolicy ([log4j]https://logging.apache.org/log4j/2.x/manual/filters.html#compositefilter).

It combines multiple triggering policies and returns true if any of the configured policies return true.


In addition, the following changes have been made.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c981ca4) 63.01% compared to head (bd31a6d) 62.96%.

Files Patch % Lines
src/append/rolling_file/policy/compound/mod.rs 40.00% 9 Missing :warning:
...ppend/rolling_file/policy/compound/trigger/time.rs 89.47% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #342 +/- ## ========================================== - Coverage 63.01% 62.96% -0.05% ========================================== Files 24 24 Lines 1560 1577 +17 ========================================== + Hits 983 993 +10 - Misses 577 584 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bconn98 commented 8 months ago

@Dirreke FYI this would need to go in a 2.0 release as it's a breaking change to the API

Dirreke commented 8 months ago

@Dirreke FYI this would need to go in a 2.0 release as it's a breaking change to the API

Agree.