Open Dirreke opened 8 months ago
Attention: 11 lines
in your changes are missing coverage. Please review.
Comparison is base (
c981ca4
) 63.01% compared to head (bd31a6d
) 62.96%.
Files | Patch % | Lines |
---|---|---|
src/append/rolling_file/policy/compound/mod.rs | 40.00% | 9 Missing :warning: |
...ppend/rolling_file/policy/compound/trigger/time.rs | 89.47% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Dirreke FYI this would need to go in a 2.0 release as it's a breaking change to the API
@Dirreke FYI this would need to go in a 2.0 release as it's a breaking change to the API
Agree.
This is a BREAKING change.
This will support CompositeTriggerPolicy ([log4j]https://logging.apache.org/log4j/2.x/manual/filters.html#compositefilter).
It combines multiple triggering policies and returns true if any of the configured policies return true.
In addition, the following changes have been made.
log_to_file_with_rolling_file
.