Closed Dirreke closed 3 months ago
@bconn98 can you please review, this seem like a great feature to add , also @Dirreke I think you'll need to rebase to get that check to pass
@estk Yup will do, I was waiting on the checks. Hadn't looked close enough to realize it was just the 1.67 issue
Attention: Patch coverage is 83.33333%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 63.56%. Comparing base (
8ab1b34
) to head (bfe961e
).
Files | Patch % | Lines |
---|---|---|
.../rolling_file/policy/compound/trigger/onstartup.rs | 81.81% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It can also close #250 .
@Dirreke thanks for your continued work hard work on this. One last comment, but looking excellent otherwise!
Thanks. I don't have envs at the moment. I think I will do it after 02/16.
Bump MSRV to 1.70 for toml
Only concern I have here is bumping MSRV, the goal is to support at least a year old compiler. Any way we can avoid that?
Toml started bumping like crazy. I locked it in my branches at the current, but we can lock it at the previous and maintain 1.69.
I will rebase it after #354
Feel free to rebase now @Dirreke
Add trigger onstartup, ref: log4j