Closed bconn98 closed 4 months ago
Attention: Patch coverage is 66.66667%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 84.61%. Comparing base (
c981ca4
) to head (4a56b4e
).
Files | Patch % | Lines |
---|---|---|
src/encode/json.rs | 50.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think we should break this up into a few separate PR's, there are too many disparate changes here to review it without sitting down for at least a few hours... which is difficult to find these days.
Can you please open separate PR's with cohesive motif's? Some possible MR's
In each PR please:
Broke into the following PRs:
Fixes #352 + Adds a ton of tests