search

estk / log4rs

A highly configurable logging framework for Rust
Apache License 2.0
1.01k stars 150 forks source link

removed outdated dependency `derivative` #351

Open xNxExOx opened 9 months ago

bconn98 commented 9 months ago

I'll take a look at this either today or tomorrow. Thanks for the PR!

codecov-commenter commented 9 months ago

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 62.69%. Comparing base (f688e38) to head (f8b06d6).

Files Patch % Lines
src/append/console.rs 0.00% 5 Missing :warning:
src/append/rolling_file/mod.rs 0.00% 5 Missing :warning:
src/encode/mod.rs 0.00% 4 Missing :warning:
src/append/file.rs 0.00% 3 Missing :warning:
src/encode/pattern/mod.rs 0.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ========================================== - Coverage 63.42% 62.69% -0.73% ========================================== Files 25 25 Lines 1572 1595 +23 ========================================== + Hits 997 1000 +3 - Misses 575 595 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bconn98 commented 9 months ago

@xNxExOx I've got a lot of the CI fixes running in my test branch. Clippy went and changed some rules on us and then toml upped their MSRV to 1.70. If you're okay waiting for that branch, you can wait it out. Otherwise see if you can tackle the Clippy warnings and update the MSRV (Cargo.toml, README, and main.yml in the workflows).

bconn98 commented 9 months ago

Test coverage updates are always appreciated. But I've got 2000+ lines of test code that should cover a majority of the project that is missing it.

bconn98 commented 9 months ago

@xNxExOx #354 is out with just the changes to fix the builds if your interested. Talking with the owner to get that merged in ASAP

bconn98 commented 9 months ago

Fixes are in main now. @xNxExOx

estk commented 8 months ago

This lgtm, @xNxExOx can you get CI passing and we'll get this merged?

xNxExOx commented 8 months ago

😕 does these checks pass on the main branch? because they seems totally unrelared to anything I changed.

bconn98 commented 8 months ago

Agreed, this is stalled on the deprecated API

bconn98 commented 4 months ago

No need to swap to this, but was checking in on alternatives and it looks like the rust language proper just swapped from derivative to https://crates.io/crates/derive-where.

xNxExOx commented 4 months ago

I see only that the job failed, but no idea why, so I am not looking into it.

bconn98 commented 4 months ago

Yup no worries. Working on getting the fix into main. Should happen this weekend or next.