search

estk / log4rs

A highly configurable logging framework for Rust
Apache License 2.0
973 stars 143 forks source link

Encode tests #359

Open bconn98 opened 4 months ago

bconn98 commented 4 months ago

Increase test coverage of the encode module.

Hard code the time string created by the json encoder for tests

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.88%. Comparing base (f688e38) to head (6dcf08c).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #359 +/- ## ========================================== + Coverage 63.42% 64.88% +1.46% ========================================== Files 25 25 Lines 1572 1572 ========================================== + Hits 997 1020 +23 + Misses 575 552 -23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bconn98 commented 4 months ago

Now that once_cell is being pulled into the standard library in 1.70, we can bump to that and utilize the new standardized interface. Or, I can make similar modifications to the once_cell version to allow for dependency injection. @estk I'll defer to you on that decision. I know 1.70 is only 8 months old.

estk commented 4 months ago

Ya lets stick to 1.69 for now

bconn98 commented 4 months ago

@estk Swapped to OnceCell instead. I kept the version using the standard library in a separate branch that I'll submit towards the middle of the year when we look at moving up.