estkme-group / lpac

C-based eUICC LPA
GNU Affero General Public License v3.0
267 stars 63 forks source link

add aarch64-linux binary release downloads #99

Closed AndySchroder closed 4 months ago

AndySchroder commented 4 months ago

For those that don't want to manually compile, please add a .zip and .deb file for aarch64-linux to https://github.com/estkme-group/lpac/releases so that we can run on 64bit arm processors.

damonto commented 4 months ago

We don’t have GitHub action ARM runner now.

AndySchroder commented 4 months ago

you mean you don't have a device to test with?

damonto commented 4 months ago

If you need a Linux aarch64 binary file, you can compile it yourself. We will add it once GitHub provides a Linux ARM runner.

AndySchroder commented 4 months ago

It compiles fine on aarch64 for me, I can do it that way, it would just be more convenient to have it pre-built.

AndySchroder commented 4 months ago

However, if you can't do aarch64 right now, it would still be better if you named the file that you do have lpac-2.0.1-x86_64.deb instead of lpac-2.0.1-Linux.deb so that it's more clear that it only works on x86_64 and not aarch64. Also, no need to put "Linux" in the file name because .deb files only work on Linux anyway, it's redundant. Also, for the standalone version, lpac-linux-x86_64.zip I'd recommend making this lpac-x86_64.tar.gz. That is common convention, you don't need to add the word "Linux" in there.

AndySchroder commented 4 months ago

Does https://github.com/uraimo/run-on-arch-action work for you to get an ARM runner?

AndySchroder commented 4 months ago

it would still be better if you named the file that you do have lpac-2.0.1-x86_64.deb instead of lpac-2.0.1-Linux.deb so that it's more clear that it only works on x86_64 and not aarch64. Also, no need to put "Linux" in the file name because .deb files only work on Linux anyway, it's redundant.

This comment is fixed in https://github.com/estkme-group/lpac/pull/109.

unixfox commented 3 months ago

hello @AndySchroder could you tell me how you compiled it in ARM? using cross compilation? or on an actual ARM device?

AndySchroder commented 3 months ago

On a raspi4.