search

estliberitas / node-thumbnails-webvtt

Video thumbnail generator generating WebVTT spec file
MIT License
30 stars 10 forks source link

crash in case regenerating spritesheet #1

Closed XenoRoot closed 9 years ago

XenoRoot commented 9 years ago

In spritesheet.js, there is a confused variable called 'sprite'

One is

6   sprite = require('node-sprite')
108 sprite.sprite(sheetName, spriteOptions, function(err, globalSprite) {

The other is

121 sprite = lodash.find(sprites, {filename: filename})

One of the two should be renamed.

Thanks for your contribution.

estliberitas commented 9 years ago

Hah, really, you're right. Will fix soon.

estliberitas commented 9 years ago

Have no time today, will do tmrw.

estliberitas commented 9 years ago

Fixed and published thumbnails-webvtt@0.0.4:

npm install thumbnails-webvtt@0.0.4 --save