search

estools / escodegen

ECMAScript code generator
BSD 2-Clause "Simplified" License
2.65k stars 335 forks source link

Update esprima to 4.0.1 #398

Closed TimvdLippe closed 4 years ago

TimvdLippe commented 5 years ago

This allows users to use a newer version of esprima in their root node_modules and make sure that escodegen uses that version, rather than its bundled 3.x version.

Closes #366 Relates to #391

sanex3339 commented 4 years ago

@michaelficarra can you merge this pr?

michaelficarra commented 4 years ago

Why is there a dependency on esprima in the first place?

sanex3339 commented 4 years ago

It used here: https://github.com/estools/escodegen/blob/master/test/preserve-blank-lines.js

sanex3339 commented 4 years ago

Also this PR is depends on 4.x version https://github.com/estools/escodegen/pull/383

michaelficarra commented 4 years ago

@sanex3339 That would be a dev dependency, but it's a regular dependency.

I see now though, it's used in the CLI: https://github.com/estools/escodegen/blob/master/bin/escodegen.js. I doubt anybody uses the CLI for anything.

sanex3339 commented 4 years ago

Anyway, modify of CLI script is not the task of this PR. Just let update it to merge https://github.com/estools/escodegen/pull/383

sanex3339 commented 4 years ago

Thank you