estools / escodegen

ECMAScript code generator
BSD 2-Clause "Simplified" License
2.64k stars 334 forks source link

Nullish coalescing support #417

Open sanex3339 opened 4 years ago

sanex3339 commented 4 years ago

I have no idea what I'm doing but it works. Probably it can be done in a more simple way.

sanex3339 commented 3 years ago

@bakkot, @michaelficarra Now let's do this!

sanex3339 commented 3 years ago

Looks like this one will take a bunch of the time too =(

sanex3339 commented 3 years ago

@bakkot may you review this please? It would be nice to get this in good form before @michaelficarra see this.

sanex3339 commented 3 years ago

@michaelficarra any news?

sanex3339 commented 3 years ago

And again two months have passed since the PR was created and still no response =(

sanex3339 commented 3 years ago

@bakkot thank you, i updated the PR: https://github.com/estools/escodegen/pull/417/commits/5646f113ae78eca9046da1b8e4ea20d4baec87ad

sanex3339 commented 3 years ago

@michaelficarra may you check it now?

sanex3339 commented 3 years ago

@michaelficarra ping. Please check this.

sanex3339 commented 3 years ago

@michaelficarra ping

sanex3339 commented 3 years ago

@michaelficarra this PR is still here. 3 months have left since it was created.

sanex3339 commented 3 years ago

@michaelficarra @Constellation ping Let's celebrate the 3rd month that is passed without any attention to this PR.

sanex3339 commented 3 years ago

@michaelficarra ping

sanex3339 commented 3 years ago

@michaelficarra please check this

sanex3339 commented 3 years ago

@michaelficarra ping

sanex3339 commented 3 years ago

@michaelficarra ping

sanex3339 commented 3 years ago

Seems it's definitely the time to create a fork.

sanex3339 commented 3 years ago

@michaelficarra Ping

sanex3339 commented 3 years ago

@michaelficarra last ping in hope that it will be merged and I wont create a fork with all my PRs

sanex3339 commented 3 years ago

I created the fork with this feature: https://www.npmjs.com/package/@javascript-obfuscator/escodegen