New option: impliedStrict

estools / escope

Escope: ECMAScript scope analyzer

BSD 2-Clause "Simplified" License

546 stars 77 forks source link

New option: impliedStrict #93

Closed nre closed 8 years ago

nre commented 8 years ago

New option: impliedStrict for implied strict mode.

Defaults to false.
Sets the Program scope to strict mode if options.ecmaVersion >= 5.
- Does not tread on the nodejsScope or module scopes, if those options are enabled.
Four tests.

Fixes #92.

michaelficarra commented 8 years ago

The test files have recently been rewritten in ES6, and CoffeeScript tests are no longer supported. Please update your PR accordingly.

nre commented 8 years ago

Tests rewritten in ES6.

nre commented 8 years ago

@Constellation @michaelficarra @nzakas

I have been using this 'implied strict mode' feature in my patched versions of Escope and ESLint without any problems. If you could merge and release this feature in Escope, then I can submit a PR to ESLint.

Thank you

michaelficarra commented 8 years ago

I'd like to give Yusuke a bit more time to review. If we don't hear from him in a few days, I will merge it.

nre commented 8 years ago

Requested change made: Rename isES5() as isStrictModeSupported().

nre commented 8 years ago

@Constellation @michaelficarra @nzakas

I hope you won't mind my pinging you again about merging and releasing this 'implied strict mode' feature.

nzakas commented 8 years ago

It's OK by me. I can merge it, just want to make sure there are no other objections.

nre commented 8 years ago

Changed the description of the second test as requested.

michaelficarra commented 8 years ago

Thanks @nre.