search

estroBiologist / pluralchum

PluralKit integration for BetterDiscord
MIT License
43 stars 12 forks source link

Add edit message support #18 #19

Closed ariagivens closed 1 year ago

ariagivens commented 1 year ago

This my stab at adding edit support for proxied messages for #18.

estroBiologist commented 1 year ago

Thanks for the PR! Just tried it out, and for the most part it seems to work great. One problem I am running into is some serious command spam when editing a proxied message. I imagine this is just due to the patched function being called more than once for whatever reason, and it could probably be fixed by adding a timeout of 1-2 seconds after editing a message.

image

ariagivens commented 1 year ago

I think? That this is what debounce is for. I can give it try later today :)

ariagivens commented 1 year ago

Okay, I've been able to replicate your issue and it seems that debounce doesn't solve it. (I even tried a couple different implementations). I'll have to look into it more when I find the time.