search

estroBiologist / pluralchum

PluralKit integration for BetterDiscord
MIT License
41 stars 11 forks source link

Aparrent conflict with BetterRoleColor #36

Open paratulip opened 9 months ago

paratulip commented 9 months ago

Enabling both BetterRoleColors by Zerebos and this plugin results proxy'd text appearing as white, rather than the color of the proxy's set user color. Only this plugin, ZeresPluginLibrary, and BetterRoleColors are enabled. Including configs for all three plugins for hopeful ease of replication.

Pluralchum.config.json ZeresPluginLibrary.config.json BetterRoleColors.config.json

SnowboundCabin commented 7 months ago

this can be fixed by adding + " !important" to the color property in the function setMessageTextColour. BRC will attempt to do its thing, but unless also set to use !important, pluralchum's will be treated as important and used. I added it on line 23881 and that fixed regular text, although it seems like it also broke headers. adding it on 23886 as well breaks all proxy recoloring, though, even though it seems reasonable looking at just that function. BRC should ignore webhooks, as they never have a role attached, but doesn't - maybe an issue should be raised to BRC's dev? Thank you for mentioning this - I was wondering why the latest update said it fixed the proxy text when it still wasn't working for me, and knowing what was causing the issue was enough to get myself a hacky fix until the developer has time/energy to fix it.

ariagivens commented 3 months ago

I couldn't replicate the issue with the latest versions of Pluralchum and BetterRoleColors. Can you confirm if it's still an issue?

SnowboundCabin commented 2 months ago

Yes, on Pluralchum 2.2.0 and BRC 0.10.2 (both latest as of writing) there is still an issue, although it's that with PC enabled, BRC will not recolor non-PK message text. This seems to happen regardless of whether BRC is set to !important or not. (Apologies for the slow reply.)