search

estruyf / unicorn-busy-server

Simple busy light server for Raspberry Pi Zero and Pimoroni Unicorn Hat
MIT License
62 stars 39 forks source link

Add Icon/Json support #1

Closed j-maynard closed 4 years ago

j-maynard commented 4 years ago

OK there is a lot more in here than just adding Icon and JSON support. There is a new rainbow option, some API changes, the inclusion of HSV support (for homekit)... The headline feature was Icon support to help the colour blind person in my primary partners house. To get there I had to add support for a JSON file format which has turned out well. I've also added support for the Unicorn Mini via a wrapper class which can detect which Unicorn you are using. This class is reusable and should help anyone wanting to use the Unicorn Phat/Hat/Mini.

estruyf commented 4 years ago

@j-maynard that looked like a very interesting and useful PR! Any reason why you closed it?

j-maynard commented 4 years ago

@estruyf I didn't want to polute your original PR with my ramblings... When I opened the PR I had forgotten GitHub tries to Merge towards to the original fork not my fork. When I realised my rookie error I closed the PR. I am happy to contribute anything you think looks good or is useful upstream :smile: