search

estruyf / vscode-community-ui-toolkit

Visual Studio Code - Community UI Toolkit
MIT License
21 stars 6 forks source link

Add tag component #17

Closed kaje94 closed 3 months ago

kaje94 commented 3 months ago

Purpose

Add tag component based on https://github.com/microsoft/vscode-webview-ui-toolkit/blob/main/src/tag/README.md

Related Issue

Resolves https://github.com/estruyf/vscode-community-ui-toolkit/issues/8

Sample screenshots

Screenshot 2024-08-22 at 05 24 20 Screenshot 2024-08-22 at 05 23 16 Screenshot 2024-08-22 at 05 23 51 Screenshot 2024-08-22 at 05 23 38
estruyf commented 3 months ago

@kaje94 looks great! Good job. Just one small remark.

kaje94 commented 3 months ago

@estruyf, Could you please clarify the remark?

estruyf commented 3 months ago

Check the code review. You used Calc, but there isn't anything to be calculated. So you can just specify the value.

kaje94 commented 3 months ago

Thanks for pointing it out. I've updated the PR.

estruyf commented 3 months ago

Thanks @kaje94!